Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mail.add_header doesn't accept a dict #1054

Closed
wants to merge 2 commits into from
Closed

fix: Mail.add_header doesn't accept a dict #1054

wants to merge 2 commits into from

Conversation

hassaku63
Copy link

Fixes #997

Headers are correctly added even if the argument of add_header is of type dict.

The current spec seems to intend that only the first key/value is added when a dict type argument is given. I couldn't figure out why this implementation.
I think the spec should apply to all keys/values that a dict argument has. The current spec is non-intuitive and confusing to users.

However, changes for supports to multiple key/value pairs could result in "breaking change", so the policy in this pull request was to keep changes to a minimum.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@hassaku63 hassaku63 closed this by deleting the head repository Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant