feat: add reply to list support #1096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a project requiring multiple reply-to addresses. Is there any update on this PR? |
childish-sambino
changed the title
Comment on lines
+1010
to
+1025
| foreach ($list as $l) { | ||
| if ($l instanceof ReplyTo ) { | ||
| $this->reply_to_list[] = $l; | ||
| } else { | ||
| if (is_array($l)) { | ||
| if (!empty($l) && $l['email'] !== '') { | ||
| $this->reply_to_list[] = new ReplyTo($l['email'], $l['name']); | ||
| } | ||
| } else { | ||
| if ($l !=='') { | ||
| $this->reply_to_list[] = new ReplyTo($l); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Thanks for the addition! Could you add some unit tests to validate the logic here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This PR add reply_to_list support to the library.
Checklist
If you have questions, please file a support ticket.