Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typings for Client.setDefaultRequest #1383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brettwillis
Copy link

Fixes

The ClientRequest type (alias of RequestOptions) in Client.setDefaultRequest has required field url.

This means, when using Client.setDefaultRequest({ httpsAgent: new https.Agent() }), for example, TypeScript will error with field url is missing.

This PR makes the type partial, so all fields are optional which reflects the actual behaviour.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@brettwillis
Copy link
Author

Also, why are issues disabled on this repo?

@ank1995it
Copy link

Facing this sonar issue :
Cross-site Request Forgery (CSRF) [High Severity][https://security.snyk.io/vuln/SNYK-JS-AXIOS-6032459] in [email protected]
introduced by @sendgrid/[email protected] > @sendgrid/[email protected] > [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants