Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly require 1 element in MailDataRequired type #1377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shammahatdivvy
Copy link

@shammahatdivvy shammahatdivvy commented Nov 12, 2022

Current type does not work with the latest versions of typescript. This updates the type so it remains an array, and not the intersection of an object and an array.

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

Current type does not work with the latest versions of typescript.
This updates the type so it remains an array, and not the intersection
of an object and an array.
@htwnavarro
Copy link

Would appreciate seeing this released 🙂

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants