Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move Bouncy Castle dependency to test scope #750

Closed
wants to merge 2 commits into from

Conversation

mrdziuban
Copy link
Contributor

Fixes

Fixes #749 by moving the Bouncy Castle dependency to the test scope

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@mrdziuban
Copy link
Contributor Author

@shrutiburman would you mind taking a look at this when you have a chance? Thank you!

Copy link

@Thunderforge Thunderforge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm not a project approver, but it looks good to me. And I'd really like to see this merged and a new version released so Snyk scans for our app can stop reporting this issue.

@k163377
Copy link

k163377 commented Jul 18, 2024

Are there any plans for this to be a merge release?

@tiwarishubham635
Copy link
Contributor

Hi @mrdziuban! This looks good to me, however, it would be better if we can bump the version 1.76 to 1.78 because that version is free from the vulnerability. Can you make this change? I'll approve and merge it

@mrdziuban
Copy link
Contributor Author

Sure thing @tiwarishubham635, just updated it to the latest 1.78.1 version.

@tiwarishubham635
Copy link
Contributor

Thanks a lot @mrdziuban! The tests are failing currently coz docker-compose has moved to v2 in github. So need to update it. I'll do it and merge this PR. Thanks again!

@tiwarishubham635
Copy link
Contributor

Fixed by #767. @mrdziuban please review it once and I'll merge it

@mrdziuban
Copy link
Contributor Author

Looks good to me, thanks @tiwarishubham635! I'll close this since the changes were included in #767

@mrdziuban mrdziuban closed this Sep 10, 2024
@mrdziuban mrdziuban deleted the remove-bouncycastle branch September 10, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on BouncyCastle
4 participants