Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding go modules for v3 #463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlaricWhitney
Copy link
Contributor

This PR adds go modules capabilities as per standard go applications. This also adheres to the go standard for versions greater than v1 by adding a v3 folder with a copy of all of the go files inside of it (see https://go.dev/blog/v2-go-modules).

To avoid duplicative work, the tests to check for non-critical files (such as the license file) has been removed from v3 so that the readme and license files do not need to be updated in multiple places moving forward.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@AlaricWhitney
Copy link
Contributor Author

I should add that there's no breaking changes with this PR.

@lopezator
Copy link
Contributor

No answer from this? This should have been a module for years 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants