Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #760 #763

Closed
wants to merge 1 commit into from
Closed

Fix #760 #763

wants to merge 1 commit into from

Conversation

Jerrgree
Copy link

@Jerrgree Jerrgree commented Oct 6, 2018

Fixes # #760

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • When sending an email with a template ID that the user does not have access to, an exception is thrown instead of sending the request

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@Jerrgree
Throw an exception if given an invalid template id
9d897dd 
Shift validation from the helper function into all API calls

Add comments

Rollback exmaple cs
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 6, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 6, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@devchas devchas added hacktoberfest difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 11, 2018
@Jerrgree Jerrgree closed this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jerrgree @SendGridDX @thinkingserious @devchas