-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade from .NET Core 2.1 to .NET Core 3.1 (#1112) #1110
Conversation
Hello @akunzai! Thank you for the PR!! Reference: https://devblogs.microsoft.com/dotnet/net-core-2-1-will-reach-end-of-support-on-august-21-2021 This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog. With best regards, Elmer Internal Tracking: DI-1564 |
A quick confirmation: These changes should not break users who choose to use this helper library on .NET Code 2.1, but rather upgrades our examples to use .NET Code 3.1? |
Yes,
|
@akunzai thank you for the PR and for keeping it up to date! This is still in the backlog waiting to be prioritized. |
…xception since .NET Core 3.0 - dotnet/runtime#21965
- merge RUN commands - curl is installed in `mcr.microsoft.com/dotnet/sdk:3.1`
3.1 is no longer supported in dec 2022. I agree with your work, but perhaps just multi-target netstandard2.0 and net6.0. |
Hi @waynebrantley, thanks for your recognition, perhaps your can open another PR to remove outdated TFMs(netstandard1.3;net452;net40). Please give this PR more thumbs up to make sendgrid/twilio raise priority of this PR. |
I would but only if we knew they were willing to merge it! |
Hi @waynebrantley and @akunzai! We definitely appreciate your contributions and will work on merging the changes on our end. I will appreciate if you can tag me once this is ready so that it doesn't get lost in my email. Thank you! |
Hi @rakatyal @eshanholtz @thinkingserious, It is ready to merge for a long while. Please consider merge it before .NET Core 3.1 goes EOL, thanks. |
Hi! Based on internal discussions, we won't be considering these changes since we will look to upgrade to .Net 6 taking into account the .Net Core EOL. Apologies for the confusion. |
Hi @rakatyal, It's OK! never mind, I'm going to close this PR, thanks for your confirmation! |
@rakatyal Seeing how the issues page has been disabled(?) I'll ask here: How are we supposed to report bugs/feature requests on this library now? The links in the README for "feature request" and "bug report" now point to a non-existing header in the CONTRIBUTING document. |
Hi @Sharparam, you can report bugs/feature requests to us through Twilio SendGrid Support Help Center. |
Fixes #1112
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.