Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade from .NET Core 2.1 to .NET Core 3.1 (#1112) #1110

Closed
wants to merge 6 commits into from
Closed

chore: Upgrade from .NET Core 2.1 to .NET Core 3.1 (#1112) #1110

wants to merge 6 commits into from

Conversation

akunzai
Copy link
Contributor

@akunzai akunzai commented May 11, 2021

Fixes #1112

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 11, 2021
@akunzai akunzai changed the title Upgrade from .NET Core 2.1 to .NET Core 3.1 Upgrade from .NET Core 2.1 to .NET Core 3.1 (#1112) May 18, 2021
@thinkingserious thinkingserious changed the title Upgrade from .NET Core 2.1 to .NET Core 3.1 (#1112) chore: Upgrade from .NET Core 2.1 to .NET Core 3.1 (#1112) May 19, 2021
@thinkingserious
Copy link
Contributor

Hello @akunzai!

Thank you for the PR!!

Reference: https://devblogs.microsoft.com/dotnet/net-core-2-1-will-reach-end-of-support-on-august-21-2021

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

With best regards,

Elmer

Internal Tracking: DI-1564

@shwetha-manvinkurke shwetha-manvinkurke removed the status: code review request requesting a community code review or review from Twilio label Aug 16, 2021
@eshanholtz
Copy link
Contributor

@akunzai

A quick confirmation: These changes should not break users who choose to use this helper library on .NET Code 2.1, but rather upgrades our examples to use .NET Code 3.1?

@akunzai
Copy link
Contributor Author

akunzai commented Aug 31, 2021

@eshanholtz

Yes,

  1. In SendGrid.csproj, the TargetFrameworks was not modified, it keeps the compatibility with .NET Core 2.1.
  2. In RetryDelegatingHandler.cs changes, the TaskCanceledException was inherited from OperationCanceledException, it keeps the compatibility too.
  3. I upgrade tests to use .NET Core 3.1 too, not just examples.

@shwetha-manvinkurke shwetha-manvinkurke added the status: work in progress Twilio or the community is in the process of implementing label Oct 22, 2021
@shwetha-manvinkurke
Copy link
Contributor

shwetha-manvinkurke commented Oct 22, 2021

@shwetha-manvinkurke
Copy link
Contributor

@akunzai thank you for the PR and for keeping it up to date! This is still in the backlog waiting to be prioritized.

@waynebrantley
Copy link

3.1 is no longer supported in dec 2022. I agree with your work, but perhaps just multi-target netstandard2.0 and net6.0.
And does sendgrid/twilio have any intent on merging this?

@akunzai
Copy link
Contributor Author

akunzai commented Sep 15, 2022

Hi @waynebrantley, thanks for your recognition, perhaps your can open another PR to remove outdated TFMs(netstandard1.3;net452;net40).

Please give this PR more thumbs up to make sendgrid/twilio raise priority of this PR.

@waynebrantley
Copy link

I would but only if we knew they were willing to merge it!
@mortenbock @rakatyal any thoughts?

@rakatyal
Copy link
Contributor

Hi @waynebrantley and @akunzai! We definitely appreciate your contributions and will work on merging the changes on our end. I will appreciate if you can tag me once this is ready so that it doesn't get lost in my email. Thank you!

@akunzai
Copy link
Contributor Author

akunzai commented Sep 23, 2022

Hi @rakatyal @eshanholtz @thinkingserious,

It is ready to merge for a long while. Please consider merge it before .NET Core 3.1 goes EOL, thanks.

@rakatyal
Copy link
Contributor

Hi! Based on internal discussions, we won't be considering these changes since we will look to upgrade to .Net 6 taking into account the .Net Core EOL. Apologies for the confusion.

@akunzai
Copy link
Contributor Author

akunzai commented Sep 30, 2022

Hi @rakatyal,

It's OK! never mind, I'm going to close this PR, thanks for your confirmation!

@akunzai akunzai closed this Sep 30, 2022
@Sharparam
Copy link

@rakatyal Seeing how the issues page has been disabled(?) I'll ask here: How are we supposed to report bugs/feature requests on this library now? The links in the README for "feature request" and "bug report" now point to a non-existing header in the CONTRIBUTING document.

@rakatyal
Copy link
Contributor

Hi @Sharparam, you can report bugs/feature requests to us through Twilio SendGrid Support Help Center.

@akunzai akunzai deleted the upgrade-dotnet-sdk-3.1 branch February 27, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants