test: Snapshot test for form message #1223

liamcho · 2024-09-26T07:40:19Z

Test sheet

https://docs.google.com/spreadsheets/d/16lv6-77jS00_8tJOPHLcB-7wgON4miFw-BfvUJFyUE4/edit?gid=0#gid=0

How to run snapshot test

yarn test:visual

Android results

https://github.com/sendbird/uikit-android/blob/develop/uikit/src/test/snapshots/images/com.sendbird.uikit_MessageFormSnapshotTest_test%20snapshot%20for%20message%20form_form-204.png

Changelogs

netlify · 2024-09-26T07:40:34Z

✅ Deploy Preview for sendbird-uikit-react ready!

Name	Link
🔨 Latest commit	`15a79ce`
🔍 Latest deploy log	https://app.netlify.com/sites/sendbird-uikit-react/deploys/6719d047bc9f250008d294a6
😎 Deploy Preview	https://deploy-preview-1223--sendbird-uikit-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

## [v3.15.5] (Oct 4th, 2024) ### Updates - Usage of template message feature: 1. Template data in message - removed: A message with valid `extendedMessagePayload.template` value will be displayed with `TemplateMessageItemBody`. - added: A message with valid `extendedMessagePayload.message_template` value will be displayed with `TemplateMessageItemBody`. 2. Container type data in message - removed: Added 'wide' width support for `MessageContent` when value exists in `message.extendedMessagePayload['ui']['container_type']` - added: Added support for template message rendering options (boolean type): `profile`, `time`, and `nickname` in `extendedMessagePayload['message_template']['container_options']`

apps/testing/src/pages/GroupChannelPage.tsx

liamcho · 2024-10-08T08:16:01Z

apps/visual-test/src/App.tsx

+import '../../../src/ui/Input/index.scss';
+import '../../../src/ui/FormMessageItemBody/index.scss';
+
+


Note that this testing app is currently implemented for Form testing only. However, this visual-test app is supposed to be for all visual tests not just form. For now lets just keep as is and later when we need to add another type of visual test other than form, we can refactor then.

__visual_tests__/__fixtures__/form/form.single.fixture.ts

liamcho · 2024-10-08T08:18:24Z

apps/visual-test/mock-data/form.ts

+  "translationTargetLanguages": [],
+  "messageSurvivalSeconds": -1,
+  "plugins": [],
+  "_poll": null


These are all random message values that form test does not care. Don't think much about it.

…mplate

.circleci/config.yml

__visual_tests__/form/form-multiple.spec.ts

__visual_tests__/form/form-single.spec.ts-snapshots/104-1-chromium-darwin.png

liamcho · 2024-10-14T06:42:02Z

...napshots/101-Form-with-one-text-input-with-number-only-regex-fill-number-1-webkit-darwin.png

input element 의 line height 가 safari에서 적용이 안되는거 같습니다. 같은 변경해도 소용이 없네요. height 는 fit-content 이여야하기 때문에 text size 를 올리던지 다른 방법을 찾아야 할 것 같습니다.

일단 이거는 그럼, 노운 이슈로 가시고 나중에 픽스하시죵

playwright.config.ts

...ext-input-no-fill-one-t-d59bb-put-no-fill-and-one-chip-input-no-select-1-chromium-darwin.png

...-text-input-no-fill-one-t-d59bb-put-no-fill-and-one-chip-input-no-select-1-webkit-darwin.png

__visual_tests__/form/form-multiple.spec.ts

bang9

LGTM, could you review this PR? @AhyoungRyu @git-babel @HoonBaek
We need at least one approval from the JS team before merging.

If you need a brief explanation before the review, please reach out to @liamcho .

…mplate

HoonBaek

Please merge for today's release

…mplate

snapshot test setup

875a031

liamcho added the DO_NOT_MERGE Do not merge this PR yet label Sep 26, 2024

liamcho requested a review from bang9 September 26, 2024 07:40

liamcho self-assigned this Sep 26, 2024

liamcho removed the request for review from bang9 September 26, 2024 07:40

liamcho marked this pull request as draft September 26, 2024 07:40

liamcho added 2 commits October 4, 2024 14:50

Added snapshot tests for form

0d75102

liamcho commented Oct 8, 2024

View reviewed changes

apps/testing/src/pages/GroupChannelPage.tsx Outdated Show resolved Hide resolved

liamcho commented Oct 8, 2024

View reviewed changes

__visual_tests__/__fixtures__/form/form.single.fixture.ts Outdated Show resolved Hide resolved

liamcho commented Oct 8, 2024

View reviewed changes

liamcho added 8 commits October 10, 2024 13:13

fix

56ddb66

fix

6eb305b

fix

35bf80c

fix

99958b0

fix

d8047f8

add more tests

edabbf0

remove comment

ab6f012

add more tests

7cb139e

liamcho requested review from bang9, HoonBaek and AhyoungRyu and removed request for HoonBaek October 10, 2024 07:16

liamcho added v3.15.6 and removed DO_NOT_MERGE Do not merge this PR yet labels Oct 10, 2024

liamcho requested a review from HoonBaek October 10, 2024 07:17

liamcho changed the title ~~[test] snapshot test setup (draft)~~ test: Snapshot test for form message Oct 10, 2024

Merge branch 'main' into test/NOTI-3489-snapshot-tests-for-message-te…

df4dc15

…mplate

liamcho marked this pull request as ready for review October 11, 2024 08:20

fix

469bc93

bang9 reviewed Oct 11, 2024

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

liamcho added 4 commits October 14, 2024 12:58

fix

6407f1c

fix

e0c973b

fix

281c361

fix

15c14db

bang9 reviewed Oct 14, 2024

View reviewed changes

__visual_tests__/form/form-multiple.spec.ts Outdated Show resolved Hide resolved

bang9 reviewed Oct 14, 2024

View reviewed changes

__visual_tests__/form/form-single.spec.ts-snapshots/104-1-chromium-darwin.png Outdated Show resolved Hide resolved

liamcho added 3 commits October 14, 2024 14:53

fix

a614abd

fix

40aee3e

fix

d537c7b

liamcho commented Oct 14, 2024

View reviewed changes

bang9 reviewed Oct 14, 2024

View reviewed changes

playwright.config.ts Outdated Show resolved Hide resolved

bang9 reviewed Oct 14, 2024

View reviewed changes

...ext-input-no-fill-one-t-d59bb-put-no-fill-and-one-chip-input-no-select-1-chromium-darwin.png Outdated Show resolved Hide resolved

bang9 reviewed Oct 14, 2024

View reviewed changes

...-text-input-no-fill-one-t-d59bb-put-no-fill-and-one-chip-input-no-select-1-webkit-darwin.png Outdated Show resolved Hide resolved

fix

9e2e090

liamcho requested a review from bang9 October 15, 2024 01:46

bang9 reviewed Oct 15, 2024

View reviewed changes

__visual_tests__/form/form-multiple.spec.ts Show resolved Hide resolved

fix

c7fc1fd

liamcho requested a review from bang9 October 15, 2024 06:09

fix

b45c304

bang9 approved these changes Oct 22, 2024

View reviewed changes

bang9 requested a review from a team October 22, 2024 02:17

liamcho added 2 commits October 22, 2024 13:39

fix

65fdf35

Merge branch 'main' into test/NOTI-3489-snapshot-tests-for-message-te…

5478d70

…mplate

HoonBaek approved these changes Oct 24, 2024

View reviewed changes

Merge branch 'main' into test/NOTI-3489-snapshot-tests-for-message-te…

15a79ce

…mplate

liamcho merged commit 2fb0d7c into main Oct 24, 2024
10 checks passed

liamcho deleted the test/NOTI-3489-snapshot-tests-for-message-template branch October 24, 2024 05:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Snapshot test for form message #1223

test: Snapshot test for form message #1223

liamcho commented Sep 26, 2024 •

edited

Loading

netlify bot commented Sep 26, 2024 •

edited

Loading

liamcho Oct 8, 2024

liamcho Oct 8, 2024

liamcho Oct 14, 2024 •

edited

Loading

bang9 Oct 15, 2024

liamcho Oct 15, 2024

bang9 left a comment

HoonBaek left a comment

		import '../../../src/ui/Input/index.scss';
		import '../../../src/ui/FormMessageItemBody/index.scss';

test: Snapshot test for form message #1223

test: Snapshot test for form message #1223

Conversation

liamcho commented Sep 26, 2024 • edited Loading

Test sheet

How to run snapshot test

Android results

Changelogs

netlify bot commented Sep 26, 2024 • edited Loading

✅ Deploy Preview for sendbird-uikit-react ready!

liamcho Oct 8, 2024

Choose a reason for hiding this comment

liamcho Oct 8, 2024

Choose a reason for hiding this comment

liamcho Oct 14, 2024 • edited Loading

Choose a reason for hiding this comment

bang9 Oct 15, 2024

Choose a reason for hiding this comment

liamcho Oct 15, 2024

Choose a reason for hiding this comment

bang9 left a comment

Choose a reason for hiding this comment

HoonBaek left a comment

Choose a reason for hiding this comment

liamcho commented Sep 26, 2024 •

edited

Loading

netlify bot commented Sep 26, 2024 •

edited

Loading

liamcho Oct 14, 2024 •

edited

Loading