Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup test cases #138

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

mhungen
Copy link

@mhungen mhungen commented Nov 19, 2024

Hello,
I am currently working on a python port of the s2tbx biophysical models.
I have used your auxdata files which contain the model parameters and conveniently a set of test case files.

However, I think there is something wrong with some of the test cases.

Some do not make sense because the structure does not match the model inputs (assuming I’ve correctly interpreted everything).

All test cases of S2B_10m should have 7 columns (6 input, 1 result), but they have 12. All of them are identical to the test cases in S2B, so this looks like a copy & paste error.

s2tbx-biophysical/src/main/resources/auxdata/3_0/S2B_10m/FAPAR/FAPAR_TestCases
s2tbx-biophysical/src/main/resources/auxdata/3_0/S2B_10m/FCOVER/FCOVER_TestCases
s2tbx-biophysical/src/main/resources/auxdata/3_0/S2B_10m/LAI/LAI_TestCases

S2A & S2B test cases for LAI_Cw provide 16 columns, i would expect 12 (11 inputs, 1 result)

s2tbx-biophysical/src/main/resources/auxdata/3_0/S2A/LAI_Cw/LAI_Cw_TestCases
s2tbx-biophysical/src/main/resources/auxdata/3_0/S2B/LAI_Cw/LAI_Cw_TestCases

And there are also some test cases that fail if i add them to your implementation

s2tbx-biophysical/src/main/resources/auxdata/3_0/S2A/LAI_Cab/LAI_Cab_TestCases

To be fair, your code doesn’t use these test cases, but the files are quite large and some of them are clearly wrong. I suggest removing them.

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

@mhungen mhungen force-pushed the cleanup_test_cases branch 2 times, most recently from 6712ca3 to 055c7fe Compare November 19, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants