fix: "no release" is the lowest priority #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prior to this commit, using a custom analysis rule that set release to `false`, for example:
```
[
{type: 'fix', scope: 'frontend', release: 'patch'},
{type: 'fix', scope: '*', release: false} // <----- this should NOT override 'patch'
]
```
would skip the release matching commits, even though another rule matches them with a higher release value. that is to say: this commit codifies `false` or `null` release values as the "lowest" release value, making it possible to treat "no release" the same way we treat all other release values, instead of treating it as a special exception. the primary use-case for this change is more granular control over commit analysis when using `scope`s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior to this commit, using a custom analysis rule that set release to
false, for example:would skip the release matching commits, even though another rule matches them with a higher release value. that is to say: this commit codifies
falseornullrelease values as the "lowest" release value, making it possible to treat "no release" the same way we treat all other release values, instead of treating it as a special exception. the primary use-case for this change is more granular control over commit analysis when usingscopesBREAKING CHANGE:
release: falsewill not override other matching release rules of higher priority