Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_scene_referred to zimg_graph_builder_params #196

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Setsugennoao
Copy link

As the title says, adds this param to the public API.

I also edited the test example to include it.
I don't know if you didn't want the changelog to be updated, I can remove it ^^

@Setsugennoao
Copy link
Author

Hi, is there anything I should modify for it to be merged? Is this not planned or wanted in the API?

@sekrit-twc
Copy link
Owner

scene_referred will be added when a verified use case arises. Otherwise, there will be much untested code exposed.

@NSQY
Copy link

NSQY commented Jun 30, 2023

scene_referred will be added when a verified use case arises. Otherwise, there will be much untested code exposed.

The original want for this option stems from this Doom9 thread: https://forum.doom9.org/showthread.php?p=1972723#post1972723

For what it's worth, AVS+ users have had access to this code for approximately a year. I will contact the maintainer to confirm.

@NSQY
Copy link

NSQY commented Jul 2, 2023

No known problems reported with the AVS+ build. Testing may be limited to the aforementioned post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants