-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the Cobertura coverage report #957
base: 9.2
Are you sure you want to change the base?
Improved the Cobertura coverage report #957
Conversation
Codecov Report
@@ Coverage Diff @@
## 9.2 #957 +/- ##
============================================
- Coverage 84.29% 84.11% -0.18%
- Complexity 1178 1235 +57
============================================
Files 59 65 +6
Lines 4215 3519 -696
============================================
- Hits 3553 2960 -593
+ Misses 662 559 -103
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @sebastianbergmann, what is the best way to get this PR reviewed and merged? |
This branch cannot be rebased due to conflicts. |
I hope to have time next week to look into this. |
Yesterday I merged the 9.2 branch into the branch of this PR and resolved the merge conflicts.
That would be nice! Thanks in advance. |
GitHub disagrees:
Sorry :( |
14dcad3
to
d26df1b
Compare
My apologies for the confusion. I just squased the commits and rebased the branch. |
Is there something I can do to get this PR merged? I think everything is ready now. |
Nothing right now, I just need to find the time to review it. |
d26df1b
to
c99f329
Compare
c99f329
to
0221768
Compare
0221768
to
51de9c8
Compare
51de9c8
to
f0a6126
Compare
The format of the Cobertura report did not match the Cobertura document definition. For example in some cases, the required attribute
name
ofpackage
and the required attributesignature
ofmethod
was empty.Resulting in tools like Jenkins not being able to interpret the report.