Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1037 - CSS fixes for first column of code review table. #1046

Merged

Conversation

gammamatrix
Copy link
Contributor

Changes

  • I did a quick test and it appears to work fine in Chrome and Firefox, but the selector does not appear to work on old Safari.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.96%. Comparing base (f0a48df) to head (898066d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1046   +/-   ##
=========================================
  Coverage     83.96%   83.96%           
  Complexity     1191     1191           
=========================================
  Files            69       69           
  Lines          4216     4216           
=========================================
  Hits           3540     3540           
  Misses          676      676           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammamatrix
Copy link
Contributor Author

Changes

table#code td:first-of-type {
  padding-left: .75em;
  padding-right: .75em;
}

table#code td:first-of-type a {
  text-decoration: none;
}
  • This appears to be working on Chrome, Firefox and Safari.
  • Did I cover the padding in the right spot?

@sebastianbergmann
Copy link
Owner

I still see the whitespace after this PR on Firefox 130 and Chrome 128:

grafik

@gammamatrix
Copy link
Contributor Author

Is that extra space just from the flex box and making the view port over 2000px?

I did a comparison... I marked the images, the two in the middle are for Firefox 130 with Bootstrap 5 on the left and Bootstrap 4 on the right.

  • The outside browsers are both Chrome:

GH-1046-chrome-128-firefox-130-with-bootstrap-4-and-5

@sebastianbergmann
Copy link
Owner

Is that extra space just from the flex box and making the view port over 2000px?

Maybe. I always have my browser windows full-screen :)

@sebastianbergmann sebastianbergmann merged commit 9ea1557 into sebastianbergmann:main Sep 7, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants