Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist/index.js: Fix typos discovered by codespell #36

Closed
wants to merge 1 commit into from
Closed

dist/index.js: Fix typos discovered by codespell #36

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 31, 2025

cclauss
cclauss commented Jan 31, 2025
View reviewed changes
dist/index.js
@@ -2573,7 +2573,7 @@ module.exports = function () {
get offset () { return _offset },
set offset (val) { _offset = val },

get encripted () { return (_flags & 1) === 1 },
get encrypted () { return (_flags & 1) === 1 },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change! Careful review, please.

@seanmiddleditch
Copy link
Owner

This is only change code inside the compiled dist/index.js, which is a generated artifact of the npm build step and should not be modified any other way. The spelling corrections found are all in code bundled in from dependencies.

The only reason dist/index.js is even checked into the repo is because GitHub Actions seems to require the bundled file, at least based on their examples/documentation.

@cclauss cclauss deleted the codespell branch February 1, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @seanmiddleditch