Add Ninja 1.12.1 support, including improved platform detection #29
+180
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahajha
commented
Aug 22, 2024
| const destDir = core.getInput('destination') || 'ninja-build' | ||
| const proxyServer = core.getInput('http_proxy') | ||
|
|
||
| const [error, platform] = selectPlatform(core.getInput('platform'), version) |
There was a problem hiding this comment.
Aside from the above function, this is the only changed line
cclauss
reviewed
Jan 21, 2025
Co-authored-by: Christian Clauss <[email protected]>
|
@seanmiddleditch Please approve the |
seanmiddleditch
previously approved these changes
Jan 31, 2025
seanmiddleditch
dismissed
their stale review
The merge-base changed after approval.
seanmiddleditch
approved these changes
Jan 31, 2025
|
Merged, thanks! Sorry for the ridiculous delay. |
|
Should the default version be raised to the current version so things work by default on Ubuntu ARM? |
|
@seanmiddleditch Just happy to have it merged! @cclauss It should be, I changed it in action.yaml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Ninja 1.12.1 (and 1.12.0) support. Ninja ships Linux and Windows ARM binaries since 1.12.0, so I've added some logic to account for that (context: https://github.com/ninja-build/ninja/releases/tag/v1.12.0)
I unfortunately have no way to test if the ARM support works, as Github doesn't have public ARM runners available.
Feel free to roast me on my JS, I normally don't write in it :) I figured the new logic was too complex to shove into a series of ternaries.
I spent way too much time trying to minimize the whitespace changes in dist/index.js, I think there's something up with the file. Saving the file even without formatting creates thousands of whitespace changes that are really hard to get git to ignore.