Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1 #101

Merged
merged 104 commits into from
Mar 1, 2018
Merged

v3.1 #101

merged 104 commits into from
Mar 1, 2018

Conversation

clhunsen
Copy link
Collaborator

@clhunsen clhunsen commented Mar 1, 2018

3.1

Added

Changed/Improved

Fixed

  • Add 'date.offset' to possible edge attributes (0c1868a)
  • Fix sqldf queries (35ea503)

Felix Prasse and others added 30 commits December 21, 2017 17:10
Add methods required to add vertex attributes to the graph.
Add method to calculate commit count as vertex attribute

Signed-off-by: Felix Prasse <[email protected]>
Signed-off-by: Felix Prasse <[email protected]>
- Rename aggregation to aggregation.level and all to project
- Rename add.vertex.attributes.* methods to add.vertex.attribute.*
- Rename compute.vertex.attribute.with.n2r to add.vertex.attribute
- Rename compute.vertex.attribute to split.and.add.vertex.attribute
- Move networks.to.ranges to util-split and
  rename it to split.data.by.networks
- Remove explicit return statement where possible
- Add missing documentation

Signed-off-by: Felix Prasse <[email protected]>
Signed-off-by: Felix Prasse <[email protected]>
Add test for add.vertex.attribute
Add test for split.and.add.vertex.attribute
Add test for add.vertex.attribute.commit.count
Add test for add.vertex.attribute.author.email
Add test for add.vertex.attribute.artifact.count
Add test for add.vertex.attribute.first.activity

Signed-off-by: Felix Prasse <[email protected]>
The tests were referencing to a wrong project data variable

Signed-off-by: Felix Prasse <[email protected]>
Add test for add.vertex.attribute.author.role.simple
Add test for add.vertex.attribute.active.ranges

Signed-off-by: Felix Prasse <[email protected]>
Add artifact attributes
Add commit count based on committer

Signed-off-by: Felix Prasse <[email protected]>
In this patch, we mainly streamline the tests on network attributes, by
applying proper line breaks, introducing global constants, and fixing
the accidental introduction of factors for the developer roles.

This tackles some comments in PR #67.

Signed-off-by: Claus Hunsen <[email protected]>
With respect to PR #67, logging statements, line breaks, and
capitalization in sqldf-statements are updated.

Signed-off-by: Claus Hunsen <[email protected]>
With respect to PR #67, indentation, line breaks, coding flaws, and
anything else is tackled.

Adds a FIXME item regarding the first activity of an author, which will
be tackled in an upcoming commit.

Signed-off-by: Claus Hunsen <[email protected]>
The section dividers always end at column 77. ;)

Signed-off-by: Claus Hunsen <[email protected]>
To get the very first and the very last activity across all data
sources, i.e., the earliest/latest timestamp of all data sources, for a
ProjectData object, we add a parameter 'outermost' to
'ProjectData$get.data.timestamps' that makes this possible.

Props to @bockthom for his support.

Signed-off-by: Claus Hunsen <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
Formerly, we provided three different aggregation levels in the function
'split.data.by.networks': namely, "range", "cumulative", and "project".
We now extend and adapt this to the levels "range", "cumulative",
"all.ranges", "project.cumulative", "project.all.ranges", and
"complete".

The various aggregation levels work as follows:
- range: The project data will be split exactly to the time ranges
         specified by the networks' names.
- cumulative: The project data will be split exactly to the time ranges
         specified by the networks' names, but in a cumulative manner.
- all.ranges"}: The project data will be split exactly to the time range
         specified by the start of the first network and end of the last
         network. All data instances will contain the same data.
- project.cumulative: The same splitting as for \code{"cumulative"}, but
         all data will start at the beginning of the project data and
         *not* at the beginning of the first network.
- project.all.ranges: The same splitting as for \code{"all.ranges"}, but
         all data will start at the beginning of the project data and
         *not* at the beginning of the first network. All data instances
         will contain the same data.
- complete: The same splitting as for \code{"all.ranges"}, but all data
         will start at the beginning of the project data and end at the
         end of the project data. All data instances will contain the
         same data.

In this patch, we properly extend all functions and tests.

Props to @bockthom for his support in parts of this patch.

Signed-off-by: Claus Hunsen <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
The function 'add.vertex.attribute.author.role' now adds author-
classification attributes based on classification results. The function
'add.vertex.attribute.author.role.function' is now the one using a
classification function as a parameter.

For this to work, we add the range identifier as a parameter to the
anonymous calculation functions for adding the vertex attributes.

Signed-off-by: Claus Hunsen <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
Signed-off-by: Claus Hunsen <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
clhunsen and others added 25 commits February 23, 2018 17:15
We just forgot to handle the project end date properly when aggregating
ranges with aggregation level "complete".

In de752f8, the same fix is applied for
the construction of overlapping ranges.

Signed-off-by: Claus Hunsen <[email protected]>
As the project end date may come from the timestamp data in a
ProjectData instance, but the end date in any range is *exclusive*, we
need to add one second (1s) when using the aggregation level "complete".
The function was implemented correctly already, but the test was not
adapted to it.

Signed-off-by: Claus Hunsen <[email protected]>
When passing exclicit bins to the functions 'split.*.time.based', the
bins are taken as is. I.e., the last bin and, thus, the last range bound
is *exclusive*.

Signed-off-by: Claus Hunsen <[email protected]>
Before now, the function 'generate.date.sequence' was not usable with
date-time strings. Now, all given parameters are parsed as POSIXct
objects first, before using them in the function.

Signed-off-by: Claus Hunsen <[email protected]>
Signed-off-by: Claus Hunsen <[email protected]>
This patch introduces only some minor fixes and inprovements to the
documentation for the changes in PR #96.

Props to @bockthom for being that precise.

Signed-off-by: Claus Hunsen <[email protected]>
Cumulative ranges

Reviewed-by: Thomas Bock <[email protected]>
By introducing the function 'verify.argument.for.parameter', we can
properly check all arguments for our classes' constructors, just in
case.

This fixes #79.

Signed-off-by: Claus Hunsen <[email protected]>
This fixes #99.

Signed-off-by: Claus Hunsen <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
For a better documentation on how to contribute to the project, we add a
contribution guide along with an issue template.

This is considered a first draft working on #47.

Signed-off-by: Claus Hunsen <[email protected]>
The file 'NEWS.md' now holds the changelog of the network library for
better overview. The main sections are "added", "changed/improved", and
"fixes".

Added: Indicating completely new functionality, such as added features
or functions (e.g., adding the splitting functionality).
Changed/improved: Indicating adapted or updated functionality (e.g.,
updating the plotting functionality with the help of another R package).
Fixed: Indicating real fixes for bugs and regressions (e.g., fixing a
typo in a function call).

Later, the upcoming sections for new versions should be added, on the
one side, automatically generated from the commit list and, on the other
side, with a self-written text, pointing out the overall synopsis and
the highlights.

Signed-off-by: Claus Hunsen <[email protected]>
Add a more precise explanation to improve understanding on how to
structure changes in commits.

Signed-off-by: Claus Hunsen <[email protected]>
Add a rule on square-brackets notation for accessing data in data.frames
or lists.
Add a rule to keep the code as simple as possible.

Improve typographical stuff.
Props to @bockthom for pointing this out.

Signed-off-by: Claus Hunsen <[email protected]>
Props to @flx5 for pointing this out.

Signed-off-by: Claus Hunsen <[email protected]>
As a result of issue #77 and the respective PRs, we can now instruct
developers to use the appropriate functions for date handling.

Signed-off-by: Claus Hunsen <[email protected]>
Signed-off-by: Claus Hunsen <[email protected]>
Update project description. Add 'issues.only.comments' in the
`ProjectConf` section. Add 'util-networks-covariates.R' to module
overview. Add remark on 'dev' branch.

Signed-off-by: Claus Hunsen <[email protected]>
The code is updated to better reflect the coding conventions modelled in
the contribution guidelines. (The only exception is the module 'core-
peripheral', which has issue #70 still pending and, thus, got a TODO
item on this.)

The main items that are being enforced:
- spaces after commas,
- spaces around equals signs,
- equals signs as assignment,
- list access using bracket notation,
- spaces before opening brackets, and
- double quotes instead of single quotes.

Note: In this patch, certainly not all issues have been covered,
especially, proper documentation, so we need to cover that in upcoming
patches. But it's a start.

Signed-off-by: Claus Hunsen <[email protected]>
This patch introduces only some minor fixes and inprovements for the
changes in PR #100:
- better specification of bugfix releases in the guideline files,
- some rewordings,
- fixing some indentation mistakes, and
- adding a missing default value in a method documenation.

Props to @bockthom for being that precise.

Signed-off-by: Claus Hunsen <[email protected]>
License, coding conventions, and two minor improvements

Reviewed-by: Thomas Bock <[email protected]>
@clhunsen clhunsen added this to the v3.1 milestone Mar 1, 2018
@clhunsen clhunsen requested a review from bockthom March 1, 2018 12:06
Copy link
Collaborator

@bockthom bockthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we reviewed all PRs leading to the current status on dev, everything is fine here.

@bockthom bockthom merged commit 0e90d61 into master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants