Skip to content

Commit

Permalink
Make xray a local import
Browse files Browse the repository at this point in the history
  • Loading branch information
vulder committed Aug 16, 2024
1 parent cf701ef commit 4d354cd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion varats/varats/experiments/vara/hot_function_experiment.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from benchbuild.extensions import compiler, run, time
from benchbuild.utils import actions
from plumbum import local
from plumbum.cmd import llvm_xray

from varats.experiment.experiment_util import (
ZippedReportFolder,
Expand Down Expand Up @@ -76,6 +75,8 @@ def __str__(self, indent: int = 0) -> str:
)

def run_instrumented_code(self) -> actions.StepResult:

Check failure on line 77 in varats/varats/experiments/vara/hot_function_experiment.py

View workflow job for this annotation

GitHub Actions / reviewdog

varats/varats/experiments/vara/hot_function_experiment.py#L77 <116>

Missing function or method docstring (missing-function-docstring)
Raw output
varats/varats/experiments/vara/hot_function_experiment.py:77:4: C0116: Missing function or method docstring (missing-function-docstring)
from plumbum.cmd import llvm_xray

Check failure on line 78 in varats/varats/experiments/vara/hot_function_experiment.py

View workflow job for this annotation

GitHub Actions / reviewdog

varats/varats/experiments/vara/hot_function_experiment.py#L78 <415>

Import outside toplevel (plumbum.cmd.llvm_xray) (import-outside-toplevel)
Raw output
varats/varats/experiments/vara/hot_function_experiment.py:78:8: C0415: Import outside toplevel (plumbum.cmd.llvm_xray) (import-outside-toplevel)

for binary in self.project.binaries:
if binary.type != BinaryType.EXECUTABLE:
# Skip libraries as we cannot run them
Expand Down

0 comments on commit 4d354cd

Please sign in to comment.