Work around yapf/sphinx bug for starred expression when calling __get…

…item__()
se-sic · Aug 29, 2024 · 3202244 · 3202244
1 parent aaaa93a
commit 3202244
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/varats-core/varats/utils/git_util.py b/varats-core/varats/utils/git_util.py
@@ -369,8 +369,13 @@ def contains_source_code(
     if not churn_config:
         churn_config = ChurnConfig.create_c_style_languages_config()
 
-    return_code = repo["show", "--exit-code", "-m", "--quiet", commit.hash,
-                       "--", *churn_config.get_extensions_repr('*.')] & RETCODE
+    git_show_args = ["show", "--exit-code", "-m", "--quiet", commit.hash, "--"]
+    git_show_args += churn_config.get_extensions_repr('*.')
+    # There should be a '*' in front of 'git_show_args' to unpack the list.
+    # However, yapf and sphinx are unable to parse this.
+    # Fortunately, plumbum seems to unpack this correctly before running.
+    # Still: fix when possible.
+    return_code = repo[git_show_args] & RETCODE
 
     if return_code == 0:
         return False