Skip to content

Implements feature based perf instrumentation comparision #2674

Implements feature based perf instrumentation comparision

Implements feature based perf instrumentation comparision #2674

Triggered via pull request July 16, 2023 19:36
Status Failure
Total duration 22s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

pre-commit.yml

on: pull_request
pre-commit
14s
pre-commit
Fit to window
Zoom out
Zoom in

Annotations

40 errors and 34 warnings
pre-commit
The process '/opt/hostedtoolcache/Python/3.11.4/x64/bin/pre-commit' failed with exit code 1
[mypy] varats-core/varats/report/tef_report.py#L172: varats-core/varats/report/tef_report.py#L172
error: Function is missing a return type annotation [no-untyped-def]
[mypy] varats-core/varats/report/tef_report.py#L172: varats-core/varats/report/tef_report.py#L172
note: Use "-> None" if function does not return a value
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L56: varats/varats/experiments/vara/feature_perf_precision.py#L56
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L120: varats/varats/experiments/vara/feature_perf_precision.py#L120
error: Argument 2 to "__init__" of "MultiPatchReport" has incompatible type "type[PerfInfluenceTraceReportAggregate]"; expected "type[TEFReportAggregate]" [arg-type]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L180: varats/varats/experiments/vara/feature_perf_precision.py#L180
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L241: varats/varats/experiments/vara/feature_perf_precision.py#L241
error: Non-overlapping identity check (left operand type: "str", right operand type: "Literal[ProjectDomains.TEST]") [comparison-overlap]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L353: varats/varats/experiments/vara/feature_perf_precision.py#L353
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L489: varats/varats/experiments/vara/feature_perf_precision.py#L489
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L555: varats/varats/experiments/vara/feature_perf_precision.py#L555
error: Non-overlapping identity check (left operand type: "str", right operand type: "Literal[ProjectDomains.TEST]") [comparison-overlap]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L658: varats/varats/experiments/vara/feature_perf_precision.py#L658
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/tables/feature_perf_precision.py#L265: varats/varats/tables/feature_perf_precision.py#L265
error: Module "varats.experiments.vara.feature_perf_precision" does not explicitly export attribute "PerfInfluenceTraceReportAggregate" [attr-defined]
[mypy] varats/varats/tables/feature_perf_precision.py#L316: varats/varats/tables/feature_perf_precision.py#L316
error: Module "varats.experiments.vara.feature_perf_precision" does not explicitly export attribute "TimeReportAggregate" [attr-defined]
[mypy] varats/varats/tables/feature_perf_precision.py#L499: varats/varats/tables/feature_perf_precision.py#L499
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/tables/feature_perf_precision.py#L508: varats/varats/tables/feature_perf_precision.py#L508
error: Incompatible return value type (got "floating[Any]", expected "float") [return-value]
[mypy] varats/varats/tables/feature_perf_precision.py#L511: varats/varats/tables/feature_perf_precision.py#L511
error: Incompatible return value type (got "floating[Any]", expected "float") [return-value]
[pylint] varats/varats/tables/feature_perf_precision.py#L68 <325>: varats/varats/tables/feature_perf_precision.py#L68
Unnecessary parens after 'elif' keyword (superfluous-parens)
[pylint] varats/varats/tables/feature_perf_precision.py#L113 <103>: varats/varats/tables/feature_perf_precision.py#L113
Variable name "gt" doesn't conform to snake_case naming style (invalid-name)
[pylint] varats/varats/tables/feature_perf_precision.py#L539 <116>: varats/varats/tables/feature_perf_precision.py#L539
Missing function or method docstring (missing-function-docstring)
pre-commit
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-python@v2, pre-commit/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L52 <223>: varats/varats/experiments/vara/feature_perf_precision.py#L52
Method '__call__' is abstract in class 'ProjectStep' but is not overridden in child class 'AnalysisProjectStepBase' (abstract-method)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L180 <246>: varats/varats/experiments/vara/feature_perf_precision.py#L180
Useless parent or super() delegation in method '__init__' (useless-parent-delegation)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L25 <611>: varats/varats/experiments/vara/feature_perf_precision.py#L25
Unused ExperimentHandle imported from varats.experiment.experiment_util (unused-import)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L25 <611>: varats/varats/experiments/vara/feature_perf_precision.py#L25
Unused VersionExperiment imported from varats.experiment.experiment_util (unused-import)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L37 <611>: varats/varats/experiments/vara/feature_perf_precision.py#L37
Unused RunVaRATracedWorkloads imported from varats.experiments.vara.feature_experiment (unused-import)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L37 <611>: varats/varats/experiments/vara/feature_perf_precision.py#L37
Unused RunVaRATracedXRayWorkloads imported from varats.experiments.vara.feature_experiment (unused-import)
[pylint] varats/varats/tables/feature_perf_precision.py#L236 <511>: varats/varats/tables/feature_perf_precision.py#L236
TODO: check, maybe we need a "very small value cut off" (fixme)
[pylint] varats/varats/tables/feature_perf_precision.py#L296 <511>: varats/varats/tables/feature_perf_precision.py#L296
TODO: check, maybe we need a "very small value cut off" (fixme)
[pylint] varats/varats/tables/feature_perf_precision.py#L517 <212>: varats/varats/tables/feature_perf_precision.py#L517
Access to a protected member __mean_time of a client class (protected-access)
[pylint] varats/varats/tables/feature_perf_precision.py#L522 <212>: varats/varats/tables/feature_perf_precision.py#L522
Access to a protected member __mean_ctx_switches of a client class (protected-access)
[pylint] varats/varats/tables/feature_perf_precision.py#L503 <238>: varats/varats/tables/feature_perf_precision.py#L503
Unused private member `OverheadData.__profiler` (unused-private-member)
[pylint] varats/varats/tables/feature_perf_precision.py#L17 <611>: varats/varats/tables/feature_perf_precision.py#L17
Unused FeaturePerfRunner imported from varats.experiments.vara.feature_perf_runner (unused-import)
[pylint] varats/varats/tables/feature_perf_precision.py#L18 <611>: varats/varats/tables/feature_perf_precision.py#L18
Unused load_tef_report imported from varats.jupyterhelper.file (unused-import)