-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java Installation Guide for Linux #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome guide that Linux users can easily follow to install Java on their systems. The steps are clear and concise!
I wrote some minor comments regarding the phrasing as well as the link URL in Java Installation Guides page.
Would it be beneficial to include SDKMAN
as an alternative installation method for Linux users? Since SDKMAN
supports Unix-based systems, this could offer users another flexible option for managing multiple Java versions. Redirecting users to the macOS guide for SDKMAN
might cause some confusion, so maybe we could consider incorporating SDKMAN
instructions directly into this guide for clarity?
tutorials/javaInstallationLinux.md
Outdated
|
||
|
||
## Installation | ||
This should be the default option for users with admin access to their system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is worded as the default option, are there other options for users (both with admin access as well as maybe those without)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfjkri it is possible to install java without admin access, but I felt that putting that option in the guide would be confusing for new users, so I omitted it. I wanted to emphasis here that these steps require extra privileges. Maybe a better way to phrase this would be to replace the whole line with "This guide assumes you have super user access."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation! I agree, mentioning non-admin installations can complicate things for new users. The revised wording should work well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfjkri great, I've included both this and the link change in the latest few commits
tutorials/javaInstallation.md
Outdated
@@ -8,4 +8,4 @@ | |||
|
|||
* [**:fab-apple: Mac**](tutorials/javaInstallationMac.html) -- If you are on a Mac and you anticipate using JavaFX in your projects, you are using the precise JDK specified in this guide. | |||
* [**:fab-windows: Windows**](tutorials/javaInstallationWindows.html) | |||
* %%**:fab-linux: Linux**: coming soon ...%% | |||
* [**:fab-linux: Linux**](tutorials/javaInstallationLinux.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to #96, this should not include the prefix tutorials/
as it is already included in the Java Installation Guides URL (I believe this change is not yet in master
however).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfjkri Thanks for pointing this out! I'll modify this accordingly for line 11 only (I think lines 9 and 10 should be updated when I sync from master).
@mfjkri Thanks for your review.
There are quite a few (reasonable) ways to install Ubuntu on Linux. For this guide I personally opted for the cli based method with minimal extra dependencies for simplicity. I can see the merits of adding the |
Author @drustanyjt Contributed via #93
Thanks for this PR @drustanyjt and reviewers. |
Main changes are:
tutorials/javaInstallationLinux.md
and some screenshotsindex.md
page to link to Linux installationtutorials/javaInstallation.md
page to link to Linux installationAs per this discussion #64 (comment). The guide covers steps to install OpenJDK 17 on Debian based distros of Linux (like Ubuntu). It assumes users have
sudo
permissions.For reference, the guide looks something like this (updated Oct 8):