-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DialogBox.fxml to fix text overrun #44
Conversation
@flexibo is this what you meant? |
@damithc Yes. I do see your point about teaching students to learn about the problem, maybe in addition to this change, we can explain what Maybe a side by side comparison? |
@JiaXinEu perhaps we can still add an explanation about why we use this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
||
![No minHeight for Label](images/javafx/OverrunDialogBox.png) | ||
|
||
</box> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the second screenshot and cropped them such that each screenshot only shows one complete DialogBox
.
Change styling of
DialogBox
directly in the FXML file.As discussed in #22, this is an alternative to PR #37