Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure HMA diagnostic report is 1.0 for integer primary/foreign key with very large values #2314

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ensure HMA diagnostic report is 1.0 for integer primary/foreign key with very large values #2314

wants to merge 2 commits into from
+92 −7

Conversation

fealho
Copy link
Member

@fealho fealho commented Dec 5, 2024

@sdv-team
Copy link
Contributor

sdv-team commented Dec 5, 2024

Task linked: CU-86b2tk38d SDV-Enterprise - HSA and HMA diagnostic report not 1.0 for integer primary/foreign key with very large values #919

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (faeef89) to head (3d55d45).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2314   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          58       58           
  Lines        6078     6078           
=======================================
  Hits         5992     5992           
  Misses         86       86
Flag Coverage Δ
integration 82.24% <50.00%> (ø)
unit 97.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho force-pushed the issue-enterprise-919 branch 2 times, most recently from bc1330b to 6e7a7f5 Compare December 6, 2024 07:35
@fealho fealho force-pushed the issue-enterprise-919 branch from 6e7a7f5 to 9ee8ce5 Compare December 6, 2024 07:52
@fealho fealho marked this pull request as ready for review December 6, 2024 15:24
@fealho fealho requested a review from a team as a code owner December 6, 2024 15:24
@fealho fealho requested review from gsheni and removed request for a team December 6, 2024 15:24
@fealho fealho requested a review from R-Palazzo December 6, 2024 15:24
@amontanez24 amontanez24 added this to the 1.17.3 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Palazzo R-Palazzo R-Palazzo approved these changes

@gsheni gsheni gsheni approved these changes

Assignees

@fealho fealho

Labels
None yet
Projects
None yet
Milestone
1.17.3
Development

Successfully merging this pull request may close these issues.
5 participants
@fealho @sdv-team @gsheni @R-Palazzo @amontanez24