Fix tests on 41 branch and temporarily disable those unfixable #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/fix-df-41
branch
from
7309009 to
802a25e
Compare
milevin
approved these changes
Oct 23, 2024
vgapeyev
approved these changes
Oct 23, 2024
| .err() | ||
| .unwrap() | ||
| .message() | ||
| .contains("is declared as non-nullable but contains null values"); |
There was a problem hiding this comment.
Should there be another assert! around this result....contains() check?
There was a problem hiding this comment.
keen eye. thanks for catching me fall
|
Also, maybe rename the PR to "Temporarily disable failing tests on 41 branch"? |
A change marking count(c) as non-null uncovered a bug that count(c) is sometimes null today, in certain windowed queries. The bug has already been fixed in DataFusion (PR 11989). Retracting the non-nullness marking would have downstream issues on compilation. Cherry picking the fix isn't feasible, without pulling many other changes the fix depends on.
clippy is temporarily disabled. It seems somehow that we're getting new clippy errors for old code. Are we running wrong Rust toolchain version?
findepi
changed the title
Most of tests is fixed, not just disabled. |
findepi
force-pushed
the
findepi/fix-df-41
branch
from
3d702e8 to
bbd0543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.