-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop GinkgoRecover from ginkgo's container nodes #2100
Drop GinkgoRecover from ginkgo's container nodes #2100
Conversation
@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik. Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc zimnx tnozicka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/assign tnozicka
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes: GinkgoRecover should only be called when we're spawning goroutines from within a run spec. We are currently calling it from almost every container node, which, in case of a failed assertion in a container node (which shouldn't happen either way, see discussion in #2098), results in silencing an error from run spec tree construction: see e.g. onsi/ginkgo#931 (comment). It only doesn't happen now on broken framework initialization because we have two container nodes which don't call GinkgoRecover.
This PR drops the GinkgoRecover calls from the remaining container nodes.
Which issue is resolved by this Pull Request:
Resolves #
/kind bug
/priority important-soon
/cc