Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managerclient: display new restore flags #4085

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

Michal-Leszczynski
Copy link
Collaborator

This PR makes it so that the new restore flags introduced in SM 3.4 are displayed in the sctool restore --dry-run output.
Example:

miles@fedora:~/scylla-manager$ ./sctool.dev restore -L s3:restoretest-my -T sm_20241023115845UTC --rate-limit 'dc1:0,dc2:1' -c myc --dry-run --restore-tables --parallel 3 --transfers 100
NOTICE: dry run mode, restore is not scheduled

Restored tables:
  - system_traces: 0 (5 tables)
  - system_distributed: 0 (1 table)
  - mks: 5.104k (1 table)

Disk size: ~5.104k

Locations:
  - s3:restoretest-my

Snapshot Tag:   sm_20241023115845UTC
Batch Size:     2
Parallel:       3
Transfers:      100
Compaction:     not allowed 
Agent CPU:      pinned 
Download Rate Limits:
  - dc1:0 MiB/s
  - dc2:1 MiB/s

Fixes #4066

@Michal-Leszczynski Michal-Leszczynski changed the title Ml/restore dp managerclient Managerclient: display new restore flags Oct 28, 2024
@Michal-Leszczynski Michal-Leszczynski marked this pull request as ready for review October 29, 2024 07:11
@Michal-Leszczynski
Copy link
Collaborator Author

@karol-kokoszka This PR is ready for review!

@Michal-Leszczynski Michal-Leszczynski merged commit e409ae4 into master Oct 30, 2024
51 checks passed
@Michal-Leszczynski Michal-Leszczynski deleted the ml/restore-dp-managerclient branch October 30, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dry-run display with restore improvement params
2 participants