Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managerclient: improve post-restore repair progress display #4083

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Michal-Leszczynski
Copy link
Collaborator

Previously all run/task properties of post-restore repair progress were taken directly from the restore progress.
This included things like start/end time, properties, status, cause and others. It resulted in misleading progress display. This commit fixes that by deliberately leaving out, inheriting, or setting interesting repair progress fields.

Fixes #4046

Previously all run/task properties of post-restore repair progress
were taken directly from the restore progress.
This included things like start/end time, properties,
status, cause and others. It resulted in misleading progress display.
This commit fixes that by deliberately leaving out, inheriting,
or setting interesting repair progress fields.

Fixes #4046
@Michal-Leszczynski Michal-Leszczynski marked this pull request as ready for review October 28, 2024 07:28
@Michal-Leszczynski
Copy link
Collaborator Author

Example:

miles@fedora:~/scylla-manager$ ./sctool.dev progress -c myc restore/8c97d022-a954-4554-a20b-84652d2ca0b3
Restore progress
Run:            9bf6cd94-95c7-11ef-bfce-0892040e83bb
Status:         RUNNING (enabling restored tables tombstone_gc)
Start time:     29 Oct 24 08:30:01 CET
Duration:       27s
Progress:       100% | 100%
Snapshot Tag:   sm_20241023115845UTC

╭────────────────────┬─────────────┬────────┬─────────┬────────────┬────────╮
│ Keyspace           │    Progress │   Size │ Success │ Downloaded │ Failed │
├────────────────────┼─────────────┼────────┼─────────┼────────────┼────────┤
│ system_traces      │        100% │      0 │       0 │          0 │      0 │
│ system_distributed │        100% │      0 │       0 │          0 │      0 │
│ mks                │ 100% | 100% │ 5.104k │  5.104k │     5.104k │      0 │
╰────────────────────┴─────────────┴────────┴─────────┴────────────┴────────╯

Post-restore repair progress
Run:            
Status:         DONE <- Different status
Start time:     29 Oct 24 08:30:27 CET <- Different time
End time:       29 Oct 24 08:30:28 CET
Duration:       0s
Progress:       100%
Intensity:      0
Parallel:       0
Datacenters:    
  - dc1
  - dc2

╭────────────────────┬────────────────────────┬──────────┬──────────╮
│ Keyspace           │                  Table │ Progress │ Duration │
├────────────────────┼────────────────────────┼──────────┼──────────┤
│ system_distributed │      view_build_status │ 100%     │ 0s       │
├────────────────────┼────────────────────────┼──────────┼──────────┤
│ system_traces      │                 events │ 100%     │ 0s       │
│ system_traces      │          node_slow_log │ 100%     │ 0s       │
│ system_traces      │ node_slow_log_time_idx │ 100%     │ 0s       │
│ system_traces      │               sessions │ 100%     │ 0s       │
│ system_traces      │      sessions_time_idx │ 100%     │ 0s       │
╰────────────────────┴────────────────────────┴──────────┴──────────╯

@Michal-Leszczynski
Copy link
Collaborator Author

@karol-kokoszka This PR is ready for review!

@Michal-Leszczynski Michal-Leszczynski changed the title Restore: improve post-restore repair progress display Managerclient: improve post-restore repair progress display Oct 29, 2024
@Michal-Leszczynski Michal-Leszczynski merged commit e89a701 into master Oct 30, 2024
51 checks passed
@Michal-Leszczynski Michal-Leszczynski deleted the ml/fix-4046 branch October 30, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants