Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't blacklist restored tables #4021

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Don't blacklist restored tables #4021

merged 2 commits into from
Sep 17, 2024

Conversation

Michal-Leszczynski
Copy link
Collaborator

@Michal-Leszczynski Michal-Leszczynski commented Sep 5, 2024

Blacklisting approach was error-prone and difficult to test (e.g. Scylla cluster might have some leftover cdc tables from previous releases that are not present in the fresh clusters).
It also allows for a more unified mechanism of excluding raft managed tables (replicated locally) from being restored.

Rebased on #4034.

Fixes #3998

@Michal-Leszczynski
Copy link
Collaborator Author

@karol-kokoszka this PR is ready for review!

pkg/scyllaclient/client_scylla.go Show resolved Hide resolved
pkg/service/restore/worker.go Outdated Show resolved Hide resolved
This approach was error-prone and difficult to test
(e.g. Scylla cluster might have some leftover cdc tables
from previous releases that are not present in the fresh clusters).
It also allows for a more unified mechanism of excluding
raft managed tables (replicated locally) from being restored.

Fixes #3998
@Michal-Leszczynski Michal-Leszczynski merged commit e44b5a1 into master Sep 17, 2024
51 checks passed
@Michal-Leszczynski Michal-Leszczynski deleted the ml/fix-3998 branch September 17, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SM backup/restore table filtering
2 participants