feat: decouple Plex as a requirement for setting up/using Overseerr

[sct]

Description

This is the first step to opening up Overseerr to allow other media server integrations. Previously, Overseerr required signing in with a Plex account to get it configured. You can now create a local account instead of using Plex. If a local account is used, you will need to connect your Plex account still to use the Plex Media Server features.

Screenshot (if UI-related)

To-Dos

• Decouple plex from the setup process
• Remove UserType from users (opens possibility for multiple user types per user)
• Add option to link/unlink Plex account from user settings (instead of only while logging in)
• Allow changing emails
• Disable Plex login when owner account does not have plex configured
• Do not allow new plex connections to accounts if owner account unlinks plex
• Force local login to be enabled if there is no plex connected
• Update cypress tests
• Successful build yarn build
• Translation keys yarn i18n:extract
• Database migration (if required)

[lgtm-com]

This pull request introduces 1 alert when merging a231eba into 30141f7 - view on LGTM.com

new alerts:

• 1 for Useless conditional

[cypress]

overseerr    Run #2653

Run Properties:   Passed #2653  •  37a1efb229: feat: decouple Plex as a requirement for setting up/using Overseerr

Project	overseerr
Branch Review	refs/pull/3015/merge
Run status	Passed #2653
Run duration	03m 22s
Commit	37a1efb229: feat: decouple Plex as a requirement for setting up/using Overseerr
Committer	Ryan Cohen
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	1
Pending	0
Skipped	0
Passing	28
View all changes introduced in this branch ↗︎

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sct]

For those who have patiently been waiting for this, it's still in progress! I am trying to sneak in time to get this done this new year's vacation. It's super close, so please wait just a little bit longer! 🙏

[DimitriDR]

I'm looking forward for this 🎉

[sypion]

Hey @sct! Just checking in and seeing how this is going. This is the final piece of the puzzle for me. Hope you've had a wonderful New Year's vacation!

[sct]

Hey @sct! Just checking in and seeing how this is going. This is the final piece of the puzzle for me. Hope you've had a wonderful New Year's vacation!

We are still working on it!

[brettp]

Is there a way to help, and most importantly, what is the estimated release date?

That's crucial information because a very viable and full featured release already exists with Jellyseerr, so if there isn't a near term road map folks will want to use that instead. Are you working with the Jellyseerr developers to pull in their improvements?

If the release date is significantly distant, it'd make sense to focus on a migration path for Jellyseerr, as well as to double down on collaboration with the devs of that project.

Please let us know the best way to collaborate to get this feature released.

[sct]

Is there a way to help, and most importantly, what is the estimated release date?

That's crucial information because a very viable and full featured release already exists with Jellyseerr, so if there isn't a near term road map folks will want to use that instead. Are you working with the Jellyseerr developers to pull in their improvements?

If the release date is significantly distant, it'd make sense to focus on a migration path for Jellyseerr, as well as to double down on collaboration with the devs of that project.

Please let us know the best way to collaborate to get this feature released.

We don't provide ETAs. We spare whatever free time we have and that's the best I can tell you in terms of delivery time.

I am aware of Jellyseerr. That's the beauty of open source. We also now have an internal roadmap with Jellyseerr devs we are referencing to get Jellyfin support back ported to Overseerr once this is merged.

I know people are waiting for this. It's close. Just hang on a bit longer.

[CEbbinghaus]

Can't wait for this to be merged. I assume this is purely a structural change to allow for jellyfin/emby but doesn't directly add them?

[tobz]

Has there been any movement here?

I have still have #3105 open which was tacitly waiting on this work to shake out, but it's not clear to me if this work has stalled entirely or what.

[OwsleyJr]

Should we keep the play on plex deep link even if plex is disconnected? Same probably goes for the import plex users button.

[OwsleyJr]

We also probably want to disable any Plex related jobs if Plex is disconnected.

[TheCatLady]

Quickly looked through the changes and don't see any obvious issues, so I'm just nitpicking here 🐱

I'm still kinda jetlagged though, so I'll look over everything again and do some testing in the next couple days 😸

It'll be great to have these changes finally merged! 🎉

[danshilm]

I've been playing with an instance without Plex configured, and I think we should not have the jobs that are related to Plex registered to be ran. Having logs referring to Plex (or any other media server really), despite not having a Plex server configured isn't a good experience, and also seems easily preventable by not registering them in the first place.

That would also give us the added benefit of not having those jobs in the UI neither, while the endpoints related to jobs would not have to be changed.

One downside would be having to re-trigger the start of the jobs once a media server is configured in the setup, but I think that should be fine?

[danshilm]

For the "Enable New Plex Sign-In" setting below, I think we should only show/allow changing that setting if a plex server is configured

[danshilm]

Without a Plex server configured, we should remove the "Import Plex Users" button from the UI on the users list page - especially since the modal only brings up "There are no Plex users to import" while the server doesn't have an admin user token to use to authenticate to the plex API.