quadratic_sorting and is_prime benchmarks
#813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! We can completely remove the debug prints in the guests for now. Just make sure to have an assert or so inside the guest to make sure we got the right answers? I'm also having trouble with |
Draft
| let heap_size = 2097152; | ||
| let pub_io_size = 16; | ||
| let program = Program::load_elf(ceno_examples::is_prime, u32::MAX).unwrap(); | ||
| let platform = setup_platform(Preset::Ceno, &program, stack_size, heap_size, pub_io_size); |
There was a problem hiding this comment.
Slight tangent: the hole setup_platform business is a bit silly.
Our Ceno platform should have maximum limits (eg we can only use RAM up to something like u32::MAX - (1<<12) or so), but the concrete limits should be automatically inferred from how much memory is actually being used in the execution.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
In preparation for #813 Also stop hard-coding the examples in the examples-builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
benches/files exercising thequadratic_sortingandis_primeexamples (the latter added in this PR). The benches target theE2EProvingsegment.I've temporarily commented out a couple of things to make things work. They need to be addressed:
debug_memory_rangesinsrc/e2e.rs.println!in guests. The reason is that the contents of these prints are stored into a memory range which is not included in writable memory when using the default heap sizes.Additionally, I've renamed
bubble_sortingtoquadratic_sortingwhich I think matches the guest code better.Later Edit:
debug_memory_rangescan be removed entirely.