Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added confirm dialog in cancel form #502

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

Naik-G
Copy link
Contributor

@Naik-G Naik-G commented May 24, 2024

A confirmation dialog was added to the cancel button to prevent immediate cancellation, as the cancel button is located right after the log, which could lead to unintended cancellations by the user.

A confirmation dialog was added to the cancel button to prevent immediate cancellation, as the cancel button is located right after the log, which could lead to unintended cancellations by the user.
@jpmckinney jpmckinney merged commit 654a905 into scrapy:master May 24, 2024
6 checks passed
@jpmckinney
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants