-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JobStatus REST web service to easily get the status of a JobEspec… #260
Conversation
scrapyd/default_scrapyd.conf
Outdated
@@ -19,6 +19,7 @@ webroot = scrapyd.website.Root | |||
[services] | |||
schedule.json = scrapyd.webservice.Schedule | |||
cancel.json = scrapyd.webservice.Cancel | |||
status.json = scrapyd.webservice.JobStatus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better name the endpoint jobstatus to be more explicit
and consistent with other ws names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't call the others jobschedule
or jobcancel
so I think I'll return this to status
.
…ially useful to poll the status of single job, to be able then to retrieve results from Item endpoint
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 68.37% 66.82% -1.56%
==========================================
Files 16 16
Lines 819 841 +22
Branches 96 103 +7
==========================================
+ Hits 560 562 +2
- Misses 230 250 +20
Partials 29 29
Continue to review full report at Codecov.
|
Hi @aleroot, welcome to scrapyd I added commented on some lines. |
Any news on this feature? Can we filter by jobid instead of returning the whole list of jobs? |
any news with this PR? |
I think only docs/api.rst needs to be updated it's a small change so it's possible to include it in 1.3 |
…te" to match "prevstate". Rename jobstatus to status, since we don\'t do "jobcancel" or "jobschedule".
Add a status.json REST endpoint to easily check the status of a single Job.
This feature can be used to poll the web service to notice when a single job has finished.
closes #5