Fix The annoyning Deprecation issue in _middlewares.py #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix The annoyning Deprecation issue by just using get_slot_key instead of _get_slot_key and remove the second param
Gallaecio
reviewed
Dec 9, 2024
| @@ -31,7 +31,7 @@ def slot_request(self, request, spider, force=False): | |||
| return | |||
|
|
|||
| downloader = self._crawler.engine.downloader | |||
| slot_id = downloader._get_slot_key(request, spider) | |||
| slot_id = downloader.get_slot_key(request) | |||
There was a problem hiding this comment.
We need to keep support for older versions of Scrapy as well:
Suggested change
| slot_id = downloader.get_slot_key(request) | |
| try: | |
| slot_id = downloader.get_slot_key(request) | |
| except AttributeError: # Scrapy < 2.12 | |
| slot_id = downloader._get_slot_key(request, spider) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
slot_requestmethod in thescrapy_zyte_api/_middlewares.pyfile. The change involves modifying the way the slot key is obtained from the downloader.scrapy_zyte_api/_middlewares.py: Changed the method call fromdownloader._get_slot_key(request, spider)todownloader.get_slot_key(request)to use the public method instead of a private one, and hide the warning logFixes #232