Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to get_slot_key() when available #232

Closed
wRAR opened this issue Dec 2, 2024 · 0 comments · Fixed by #234
Closed

Switch to get_slot_key() when available #232

wRAR opened this issue Dec 2, 2024 · 0 comments · Fixed by #234

Comments

@wRAR
Copy link
Contributor

wRAR commented Dec 2, 2024

We call a deprecated protected method _get_slot_key() at

scrapy-zyte-api/scrapy_zyte_api/_middlewares.py

Line 34 in 5fbf0bc

slot_id = downloader._get_slot_key(request, spider)
, we should call get_slot_key() when available (Scrapy 2.12.0+).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix The annoyning Deprecation issue in _middlewares.py ahmed-ellaban/scrapy-zyte-api
1 participant
@wRAR