-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support annotated deps in serialization and testing. #201
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 98.47% 98.51% +0.04%
==========================================
Files 31 32 +1
Lines 1438 1479 +41
==========================================
+ Hits 1416 1457 +41
Misses 22 22
|
web_poet/page_inputs/annotated.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a dep but a helper class so maybe it shouldn't be in page_inputs
, not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to move it to web_poet.annotated
and remove it from the top-level __init__.py
.
No description provided.