Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support annotated deps in serialization and testing. #201

Merged
merged 7 commits into from
Mar 4, 2024
Merged

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Feb 26, 2024

No description provided.

web_poet/serialization/api.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Merging #201 (6bfb58f) into master (6db4370) will increase coverage by 0.04%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 6bfb58f differs from pull request most recent head 52371ec. Consider uploading reports for the commit 52371ec to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   98.47%   98.51%   +0.04%     
==========================================
  Files          31       32       +1     
  Lines        1438     1479      +41     
==========================================
+ Hits         1416     1457      +41     
  Misses         22       22              
Files Coverage Δ
web_poet/__init__.py 100.00% <ø> (ø)
web_poet/page_inputs/__init__.py 100.00% <100.00%> (ø)
web_poet/page_inputs/annotated.py 100.00% <100.00%> (ø)
web_poet/serialization/api.py 100.00% <100.00%> (ø)
web_poet/serialization/functions.py 99.09% <100.00%> (+0.16%) ⬆️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a dep but a helper class so maybe it shouldn't be in page_inputs, not sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to move it to web_poet.annotated and remove it from the top-level __init__.py.

setup.py Outdated Show resolved Hide resolved
@wRAR wRAR merged commit 46d3a4e into master Mar 4, 2024
17 checks passed
@wRAR wRAR deleted the annotated-support branch March 4, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants