Code

Introduce SelectFields — alternative#138

Code

Open

BurnzZ wants to merge 10 commits intofeat-fields-disabledscrapinghub/web-poet:feat-fields-disabledfrom feat-select-fields-2scrapinghub/web-poet:feat-select-fields-2Copy head branch name to clipboard

+803-17

Commits

Commits on Mar 1, 2023

• introduce SelectField to ItemPage

  BurnzZ

  committed
  9d0d150

• implement item_from_select_fields and fields_to_extract

  BurnzZ

  committed
  50ba2b6

• revert mypy tests for on_unknown_field

  BurnzZ

  committed
  db2e5ce

• avoid using kw_only in pages by using converter in ItemPage for SelectFields

  BurnzZ

  committed
  e3c6a52

• handle invalid SelectField usage

  BurnzZ

  committed
  1d4240e

• update item_from_select_fields() to always call .to_item()

  BurnzZ

  committed
  6de5cc0

• improve docstrings and type annotations

  BurnzZ

  committed
  227b610

• add call_counter to all tests

  BurnzZ

  committed
  77b06ca

• fix rebase conflict in _skip_nonitem_fields

  BurnzZ

  committed
  0096c8e

Commits on Mar 2, 2023

• ensure parity with skip_nonitem_fields

  BurnzZ

  committed
  e316cc9