Require form2request 0.1.1

scrapinghub · Jul 12, 2024 · a7f6054 · a7f6054
1 parent f5ddea5
commit a7f6054
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 12 deletions.
diff --git a/setup.py b/setup.py
@@ -20,7 +20,7 @@
     entry_points={"pytest11": ["web-poet = web_poet.testing.pytest"]},
     install_requires=[
         "attrs >= 21.3.0",
-        "form2request >= 0.1.0",
+        "form2request >= 0.1.1",
         "parsel >= 1.8.1",
         "url-matcher >= 0.2.0",
         "multidict >= 0.5.0",

diff --git a/tests/test_page_inputs.py b/tests/test_page_inputs.py
@@ -1,9 +1,7 @@
 import codecs
-import importlib.metadata
 import json
 
 import aiohttp.web_response
-import packaging.version
 import parsel
 import pytest
 import requests
@@ -23,11 +21,6 @@
 )
 from web_poet.page_inputs.http import request_fingerprint
 
-FORM2REQUEST_VERSION = packaging.version.parse(
-    importlib.metadata.version("form2request")
-)
-FORM2REQUEST_0_1_0 = packaging.version.parse("0.1.0")
-
 
 @pytest.mark.parametrize("body_cls", [HttpRequestBody, HttpResponseBody])
 def test_http_body_hashable(body_cls) -> None:
@@ -298,9 +291,6 @@ def test_http_request_from_form_select_no_selected() -> None:
     assert request.body == b"query=&bar=code&baz=ooka"
 
 
-@pytest.mark.skipif(
-    FORM2REQUEST_VERSION <= FORM2REQUEST_0_1_0, reason="form2request bug fixed in 0.1.1"
-)
 def test_http_request_from_form_select_no_options() -> None:
     url = "https://example.com"
     response = HttpResponse(

diff --git a/tox.ini b/tox.ini
@@ -67,7 +67,7 @@ deps =
     zyte-common-items==0.1.0
     aiohttp==3.7.0
     attrs==21.3.0
-    form2request==0.1.0
+    form2request==0.1.1
     parsel==1.8.1
     url-matcher==0.2.0
     tldextract==3.0.0