Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider for RequestUrl #76

Merged
merged 10 commits into from
Jun 17, 2022

Conversation

Gallaecio
Copy link
Member

We might want to add 1 more test once we merge #62, featuring a page object that uses additional requests, to make sure those work even if the original callback gets a dummy request (they should, but to me it seems worth testing nonetheless).

@Gallaecio Gallaecio requested review from kmike and BurnzZ June 15, 2022 10:30
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #76 (d24a7d9) into master (e4589e6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head d24a7d9 differs from pull request most recent head 05f1bfd. Consider uploading reports for the commit 05f1bfd to get more accurate results

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   97.76%   97.79%   +0.02%     
==========================================
  Files          10       10              
  Lines         448      454       +6     
==========================================
+ Hits          438      444       +6     
  Misses         10       10              
Impacted Files Coverage Δ
scrapy_poet/middleware.py 100.00% <100.00%> (ø)
scrapy_poet/page_input_providers.py 95.38% <100.00%> (+0.38%) ⬆️

scrapy_poet/middleware.py Outdated Show resolved Hide resolved
tests/test_middleware.py Outdated Show resolved Hide resolved
scrapy_poet/middleware.py Outdated Show resolved Hide resolved
Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Gallaecio Gallaecio merged commit 21b397c into scrapinghub:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants