Remove uses of the deprecated scrapy.utils.reqser module (#74)

CHANGELOG.rst

@@ -13,6 +13,7 @@ TBR
       ``OverridesRegistry`` which provides a wide variety of features
       for better URL matching.
     * This resuls in a newer format in the ``SCRAPY_POET_OVERRIDES`` setting.
+* Removal of this deprecated module: ``scrapy.utils.reqser``
 
 
 0.3.0 (2022-01-28)

scrapy_poet/page_input_providers.py

@@ -16,7 +16,6 @@
 from scrapy import Request
 from scrapy.http import Response
 from scrapy.crawler import Crawler
-from scrapy.utils.reqser import request_to_dict
 from scrapy.utils.request import request_fingerprint
 
 from scrapy_poet.injection_errors import MalformedProvidedClassesError
@@ -175,7 +174,7 @@ def fingerprint(self, to_provide: Set[Callable], request: Request) -> str:
         request_keys = {"url", "method", "body"}
         request_data = {
             k: str(v)
-            for k, v in request_to_dict(request).items()
+            for k, v in request.to_dict().items()
             if k in request_keys
         }
         fp_data = {

tests/test_callback_for.py

@@ -1,6 +1,5 @@
 import scrapy
 import pytest
-from scrapy.utils.reqser import request_to_dict
 
 from web_poet.pages import ItemPage, ItemWebPage
 from scrapy_poet import (
@@ -59,7 +58,7 @@ def test_default_callback():
     """Sample request not specifying callback."""
     spider = MySpider()
     request = scrapy.Request('http://example.com/')
-    request_dict = request_to_dict(request, spider)
+    request_dict = request.to_dict(spider=spider)
     assert isinstance(request_dict, dict)
     assert request_dict['url'] == 'http://example.com/'
     assert request_dict['callback'] is None
@@ -69,13 +68,13 @@ def test_instance_method_callback():
     """Sample request specifying spider's instance method callback."""
     spider = MySpider()
     request = scrapy.Request('http://example.com/', callback=spider.parse_item)
-    request_dict = request_to_dict(request, spider)
+    request_dict = request.to_dict(spider=spider)
     assert isinstance(request_dict, dict)
     assert request_dict['url'] == 'http://example.com/'
     assert request_dict['callback'] == 'parse_item'
 
     request = scrapy.Request('http://example.com/', callback=spider.parse_web)
-    request_dict = request_to_dict(request, spider)
+    request_dict = request.to_dict(spider=spider)
     assert isinstance(request_dict, dict)
     assert request_dict['url'] == 'http://example.com/'
     assert request_dict['callback'] == 'parse_web'
@@ -87,7 +86,7 @@ def test_inline_callback():
     cb = callback_for(FakeItemPage)
     request = scrapy.Request('http://example.com/', callback=cb)
     with pytest.raises(ValueError) as exc:
-        request_to_dict(request, spider)
+        request.to_dict(spider=spider)
 
     msg = f'Function {cb} is not an instance method in: {spider}'
     assert str(exc.value) == msg