Make the html cleaning for microdata faster #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 87.78% 87.73% -0.06%
==========================================
Files 11 11
Lines 475 473 -2
Branches 103 103
==========================================
- Hits 417 415 -2
Misses 52 52
Partials 6 6
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 87.78% 87.73% -0.06%
==========================================
Files 11 11
Lines 475 473 -2
Branches 103 103
==========================================
- Hits 417 415 -2
Misses 52 52
Partials 6 6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @kmike!
Here is a small tweak to the #119.
However, according to my recent performance tests, the code from #119 doesn't affect performance and the code from this PR doesn't improve anything, so from my point of view, we may just close it.
Re technicals - it turned out that we can clean HTML just a single time, but without cleaning and tags.