Draft
Conversation
emmiegit
force-pushed
the
deepwell-integration-testing
branch
from
208859c to
687f072
Compare
This comment was marked as resolved.
This comment was marked as resolved.
emmiegit
force-pushed
the
deepwell-integration-testing
branch
from
fefc7c1 to
48c5452
Compare
Was out-of-date.
Apparently markdown treats 4-indented sections as code blocks, which doc tests are trying to run.
Empty replacement is tested in a should_panic test below.
This panic has never been helpful, being so much of a false positive that the panic message itself was modified. It also appears frequently in integration tests, where it doesn't even fail the build, showing how much of a needless, unhelpful indicator it is.
Trying to avoid the word "special", which I've been using too much.
emmiegit
force-pushed
the
deepwell-integration-testing
branch
from
48c5452 to
1edaffd
Compare
emmiegit
force-pushed
the
deepwell-integration-testing
branch
from
1edaffd to
a69b6d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a long-overdue change, it implements proper integration tests for DEEPWELL as an internal API service.
This uses
tests/, the integration test directory for Rust, to create separate binaries which start an instance which connects to a local resources (e.g. S3, database, etc.) in order to perform tests using DEEPWELL endpoints as the point of entry. In order to do this, we addlib.rsas a dummy file to create a basic "library" version of DEEPWELL that the test runners can use to run a non-server instance.