Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds line numbers to pretty diff #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions diff.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,42 @@ module.exports = function( args, fn ) {

function splitByFile( diff ) {
var filename,
files = {};
files = {},
matches,
oldLineNum,
newLineNum;

diff.split( "\n" ).forEach(function( line, i ) {
if ( line.charAt( 0 ) === "d" ) {
filename = line.replace( /^diff --git a\/(\S+).*$/, "$1" );
files[ filename ] = [];
oldLineNum = null;
} else if ( matches = line.match( /@@\ -[0-9]+(,[0-9]+)?\ \+([0-9]+)(,[0-9]+)?\ @@.*/ ) ) {
oldLineNum = newLineNum = matches[ 2 ];
files[ filename ].push({
line: line,
oldLineNum: null,
newLineNum: null
});
} else if ( matches = line.match( /^(\[[0-9;]+m)*([\ +-])/ ) ) {
files[ filename ].push({
line: line,
oldLineNum: oldLineNum,
newLineNum: newLineNum
});
if ( matches[ 2 ] != '-' ) {
newLineNum++;
}
if ( matches[ 2 ] != '+' ) {
oldLineNum++;
}
} else {
files[ filename ].push({
line: line,
oldLineNum: null,
newLineNum: null
});
}

files[ filename ].push( line );
});

return files;
Expand Down
2 changes: 1 addition & 1 deletion gist-diff.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ diff( args.join( " " ), function( error, parsedDiff ) {
var files = {};
for ( var file in parsedDiff ) {
files[ file.replace( /\//g, "-" ) + ".diff" ] = {
content: parsedDiff[ file ].join( "\n" )
content: parsedDiff[ file ].map(function(data) { return data.line; }).join( "\n" )
};
}

Expand Down
16 changes: 11 additions & 5 deletions pretty-diff.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ function generatePrettyDiff( parsedDiff ) {

for ( var file in parsedDiff ) {
diffHtml += "<h2>" + file + "</h2>" +
"<div class='file-diff'><div>" +
"<div class='file-diff'><table>" +
markUpDiff( parsedDiff[ file ] ) +
"</div></div>";
"</table></div>";
}

fs.writeFileSync( "/tmp/diff.html", template.replace( "{{diff}}", diffHtml ) );
Expand All @@ -51,10 +51,16 @@ var markUpDiff = function() {
.replace( /\t/g, " " );
}

function lineNumTemplate( oldNum, newNum, type ) {
var remove = type == '+' ? '' : oldNum,
add = type == '-' ? '' : newNum;
return '<td class="line-number">' + (remove || '') + '</td><td class="line-number">' + (add || '') + '</td>';
}

return function( diff ) {
return diff.map(function( line ) {
var type = line.charAt( 0 );
return "<pre class='" + diffClasses[ type ] + "'>" + escape( line ) + "</pre>";
return diff.map(function( lineData ) {
var type = lineData.line.charAt( 0 );
return '<tr class="line ' + diffClasses[ type ] + '">' + lineNumTemplate( lineData.oldLineNum, lineData.newLineNum, type ) + '<td><pre>' + escape( lineData.line ) + '</pre></td></tr>';
}).join( "\n" );
};
}();
20 changes: 14 additions & 6 deletions template.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#wrapper {
display: inline-block;
margin-top: 1em;
min-width: 800px;
max-width: 800px;
text-align: left;
}
h2 {
Expand All @@ -31,17 +31,25 @@
border: 1px solid #d8d8d8;
margin-bottom: 1em;
overflow: auto;
padding: 0.5em 0;
}
.file-diff > div {
width: 100%:
.file-diff > table {
border-spacing: 0;
width: 100%;
}
pre {
margin: 0;
.line {
font-family: "Bitstream Vera Sans Mono", Courier, monospace;
font-size: 12px;
}
.line-number {
color: #aaa;
border-right: 1px solid #e5e5e5;
padding: 0 8px;
}
pre {
margin: 0;
line-height: 1.4em;
text-indent: 0.5em;
display: inline-block;
}
.file {
color: #aaa;
Expand Down