Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cystatsd
does not have to depend on cython for user. If we include generated filecystatsd/collector/collector.cpp
we can shipcystatsd
without cython. However, if user has cython installed it will be used to regenerate that file. You can find information about this in http://stackoverflow.com/questions/4505747/how-should-i-structure-a-python-package-that-contains-cython-code . This is even recommended by cython itself http://docs.cython.org/en/latest/src/reference/compilation.html#distributing-cython-modules . You won't to regenerate that file when something changes because I edited implementation ofsdist
so the file is regenerated each timesdist
is called and something in source files changed.