Add external ics calendar features #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes some calendar styling and adds timezone information to page.
✅ Deploy Preview for scientific-python-org ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please see the alternative implementation at #519, as well as the question there: does it make sense for us to display external calendars, when we cannot guarantee that they are current? |
|
The referenced yaml2ics PRs got closed without merging, so I suppose this should be closed now, too. Please reopen if you think I misunderstood the situation. |
|
No, I think that's correct; unfortunately, I don't think we can host external calendars, unless we rebuild the site daily to ensure that we capture all external calendars. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes some calendar styling and adds timezone information to page. This PR depends on scientific-python/yaml2ics#71
Also adds the pandas community calendar - cc @noatamir @MarcoGorelli
Closes ##246