Temporary v5.api with side-effect free set-options! and merge-options!#32
Draft
Temporary v5.api with side-effect free set-options! and merge-options!#32
Conversation
| (defn set-options! | ||
| \"Replaces *options* with options\" | ||
| [options] | ||
| (vary-meta options merge {:kindly/merge-options true})) |
Contributor
There was a problem hiding this comment.
should this be set-options? currently both set-options! and merge-options do the same thing
| " (known-kinds all-kinds))) | ||
|
|
||
| (defn api-ns-v5 [all-kinds] | ||
| (str "(ns scicloj.kindly.v5.api |
Contributor
There was a problem hiding this comment.
can we stick with v4? Is it necessary to move to v5?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This temporarily adds a v5.api-namespace, just to test current Clay and Clay with read-kinds in the same process.