Skip to content

feat: Raise gracefully if #by is not set. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2024
Merged

feat: Raise gracefully if #by is not set. #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/time_range/time.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ def initialize(time, by = nil)
end

def succ
raise ArgumentError, 'by() not set for this TimeRange' if !@by || @by.empty?

next_time = Advancer.advance_time(@time, @by)
return self.class.new(next_time, @by)
end
Expand Down
7 changes: 7 additions & 0 deletions spec/time_range_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@
end

shared_examples 'it has a begin' do
it 'raises gracefully if #by is not called' do
range = described_class.new(first, last)
expect {
range.first(1)
}.to raise_error ArgumentError, /by\(\) not set for this TimeRange/
end

describe '#begin' do
it 'has a begin' do
expect(range.begin).to eq first
Expand Down
Loading