Satisfy clippy.

schungx · Sep 6, 2023 · 5acd18c · 5acd18c
1 parent 9f6d5ae
commit 5acd18c
Show file tree

Hide file tree

Showing 25 changed files with 515 additions and 471 deletions.
diff --git a/src/func/builtin.rs b/src/func/builtin.rs
@@ -359,8 +359,25 @@ pub fn get_builtin_binary_op_fn(op: &Token, x: &Dynamic, y: &Dynamic) -> Option<
                     Divide              => impl_op!(FLOAT => $xx / $yy),
                     Modulo              => impl_op!(FLOAT => $xx % $yy),
                     PowerOf             => impl_op!(FLOAT => $xx.powf($yy as FLOAT)),
+
+                    #[cfg(feature = "unchecked")]
                     EqualsTo            => impl_op!(FLOAT => $xx == $yy),
+                    #[cfg(not(feature = "unchecked"))]
+                    EqualsTo            => Some((|_, args| {
+                        let x = args[0].$xx().unwrap() as FLOAT;
+                        let y = args[1].$yy().unwrap() as FLOAT;
+                        Ok(((x - y).abs() <= FLOAT::EPSILON).into())
+                    }, false)),
+
+                    #[cfg(feature = "unchecked")]
                     NotEqualsTo         => impl_op!(FLOAT => $xx != $yy),
+                    #[cfg(not(feature = "unchecked"))]
+                    NotEqualsTo         => Some((|_, args| {
+                        let x = args[0].$xx().unwrap() as FLOAT;
+                        let y = args[1].$yy().unwrap() as FLOAT;
+                        Ok(((x - y).abs() > FLOAT::EPSILON).into())
+                    }, false)),
+
                     GreaterThan         => impl_op!(FLOAT => $xx > $yy),
                     GreaterThanEqualsTo => impl_op!(FLOAT => $xx >= $yy),
                     LessThan            => impl_op!(FLOAT => $xx < $yy),

diff --git a/src/func/call.rs b/src/func/call.rs
diff --git a/src/func/native.rs b/src/func/native.rs
@@ -316,8 +316,8 @@ impl<'a> NativeCallContext<'a> {
                 result.try_cast_raw().map_err(|r| {
                     let result_type = self.engine().map_type_name(r.type_name());
                     let cast_type = match type_name::<T>() {
-                        typ @ _ if typ.contains("::") => self.engine.map_type_name(typ),
-                        typ @ _ => typ,
+                        typ if typ.contains("::") => self.engine.map_type_name(typ),
+                        typ => typ,
                     };
                     ERR::ErrorMismatchOutputType(
                         cast_type.into(),
@@ -349,8 +349,8 @@ impl<'a> NativeCallContext<'a> {
                 result.try_cast_raw().map_err(|r| {
                     let result_type = self.engine().map_type_name(r.type_name());
                     let cast_type = match type_name::<T>() {
-                        typ @ _ if typ.contains("::") => self.engine.map_type_name(typ),
-                        typ @ _ => typ,
+                        typ if typ.contains("::") => self.engine.map_type_name(typ),
+                        typ => typ,
                     };
                     ERR::ErrorMismatchOutputType(
                         cast_type.into(),

diff --git a/src/lib.rs b/src/lib.rs
@@ -66,7 +66,7 @@
 // #![warn(clippy::pedantic)]
 // #![warn(clippy::nursery)]
 #![warn(clippy::cargo)]
-// #![warn(clippy::undocumented_unsafe_blocks)]
+#![warn(clippy::undocumented_unsafe_blocks)]
 #![allow(clippy::unit_arg)]
 #![allow(clippy::missing_errors_doc)]
 #![allow(clippy::missing_panics_doc)]
@@ -80,6 +80,7 @@
 #![allow(clippy::upper_case_acronyms)]
 #![allow(clippy::match_same_arms)]
 // The lints below can be turned off to reduce signal/noise ratio
+#![allow(clippy::cognitive_complexity)]
 #![allow(clippy::too_many_lines)]
 #![allow(let_underscore_drop)]
 #![allow(clippy::absurd_extreme_comparisons)]