KeyboardInput experiment #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe
commented
Jun 7, 2019
| @@ -52,21 +52,20 @@ let createElement = (~children as _, ()) => | |||
| (hooks, | |||
| switch(state.gameState) { | |||
| | Stop => ( | |||
| <View | |||
| ref={r => Focus.focus(r)} | |||
There was a problem hiding this comment.
The KeyboardInput at least lets us remove this ref/focus handling (handles it under the hood for us). Since the <KeyboardInput /> also grabs input if its lost - it seemed to work more reliably for me when clicking on the screen.
There was a problem hiding this comment.
Ah!I like that <Keyboard /> handles ref/focus under the hood!
|
@bryphe sorry I just noticed your PR! Sorry for the late reply. 😅 But I think the changes you suggested make more sense semantically. Thank you for your help here! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @benschinn !
Just an experiment adding the
<KeyboardInput />from this PR: revery-ui/revery#509Also experimented with some of the semantic components we have now (
<Center />,<Container />) - feel free to use theStyleinstead though (whichever you prefer).