Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix algorithm/lcm_normal #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix algorithm/lcm_normal #44

wants to merge 1 commit into from
+3 −2

Conversation

Kuri174
Copy link
Contributor

@Kuri174 Kuri174 commented Oct 31, 2019

No description provided.

@Kuri174 Kuri174 added the completed 採点を要求 label Oct 31, 2019
uzimaru0000
uzimaru0000 requested changes Nov 7, 2019
View reviewed changes
src/algorithm/lcm_normal.py
return 0
import math
def lcm(a, b) :
return a * b // math.gcd(a, b)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すでに実装しているgcdを使ってみてください.

@uzimaru0000 uzimaru0000 added the improve [TA] 改善の余地あり label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzimaru0000 uzimaru0000 uzimaru0000 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
completed 採点を要求 improve [TA] 改善の余地あり
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kuri174 @uzimaru0000