Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reactivate types checking #4467

Merged
merged 8 commits into from
Nov 25, 2024
Merged

reactivate types checking #4467

merged 8 commits into from
Nov 25, 2024

Conversation

MonPote
Copy link
Contributor

@MonPote MonPote commented Nov 4, 2024

Component:

Context:

Summary:

Acceptance criteria:

Closes: #ISSUE_NUMBER

@MonPote MonPote requested a review from a team as a code owner November 4, 2024 15:29
@bert-e
Copy link
Contributor

bert-e commented Nov 4, 2024

Hello monpote,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 4, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Nov 18, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Nov 19, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@MonPote MonPote changed the title fix reactivate types checking Nov 19, 2024
@MonPote MonPote force-pushed the improvement/ARTESCA-13131-reactivate-type-checking branch from 7c26eaf to de04ecd Compare November 21, 2024 13:43
@bert-e
Copy link
Contributor

bert-e commented Nov 21, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@MonPote MonPote force-pushed the improvement/ARTESCA-13131-reactivate-type-checking branch from 326ace1 to 2fe9e0b Compare November 21, 2024 15:44
@bert-e
Copy link
Contributor

bert-e commented Nov 22, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@MonPote
Copy link
Contributor Author

MonPote commented Nov 23, 2024

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 23, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 25, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@MonPote @hervedombya
fix
04a4941
@MonPote @hervedombya
fix types
7f651ff
@MonPote @hervedombya
fix shell-ui types
cc8f418
@MonPote @hervedombya
update @mf-types for metalk8s-ui
6017825
@MonPote @hervedombya
update core-ui and module federation
008e54b
@MonPote @hervedombya
reactivate type checking
fa19a76
@MonPote @hervedombya
recreate package-lock.json
6f7cd78
@MonPote @hervedombya
align react @type version to others repositories
14a55a3 
add @mf-types to .gitignore

remove unused type definitions and package.json files from react-query and core-ui

Revert "remove unused type definitions and package.json files from react-query and core-ui"

This reverts commit 0352388.

Revert "add @mf-types to .gitignore"

This reverts commit 84dff91.
@hervedombya hervedombya force-pushed the improvement/ARTESCA-13131-reactivate-type-checking branch from 6dec7d5 to 14a55a3 Compare November 25, 2024 10:27
@bert-e
Copy link
Contributor

bert-e commented Nov 25, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/129.0

The following branches have NOT changed:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/126.0
  • development/127.0
  • development/128.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue ARTESCA-13131.

Goodbye monpote.

The following options are set: approve

@bert-e bert-e merged commit 14a55a3 into development/129.0 Nov 25, 2024
27 checks passed
@bert-e bert-e deleted the improvement/ARTESCA-13131-reactivate-type-checking branch November 25, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWatenbergScality JBWatenbergScality JBWatenbergScality approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MonPote @bert-e @JBWatenbergScality